Register FIS Handlers #4389
Merged
Register FIS Handlers #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxx0624
reviewed
Oct 8, 2024
agent/handlers/task_server_setup.go
Outdated
| @@ -98,7 +98,7 @@ func taskServerSetup( | |||
|
|
|||
| // TODO: Future PR to pass in TMDS server router once all of the handlers have been implemented. | |||
There was a problem hiding this comment.
seems we can remove the TODO
amogh09
previously approved these changes
Oct 8, 2024
… list of capabilities on EXTERNAL
amogh09
approved these changes
Oct 8, 2024
mye956
approved these changes
Oct 8, 2024
harishxr
added a commit
to harishxr/amazon-ecs-agent
that referenced
this pull request
Oct 11, 2024
… list of capabilities on EXTERNAL (aws#4389)
amogh09
pushed a commit
to amogh09/amazon-ecs-agent
that referenced
this pull request
Oct 21, 2024
… list of capabilities on EXTERNAL (aws#4389)
amogh09
pushed a commit
that referenced
this pull request
Oct 25, 2024
… list of capabilities on EXTERNAL (#4389)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the registration of fault handlers to the task API server setup in the taskServerSetup() function and also adds
attributePrefix + capabilityFaultInjectiontoexternalUnsupportedCapabilities.Implementation details
Testing
New tests cover the changes: no
Manual testing:
blackholeport,latencyandpacketlossfaults in bothhostandawsvpcmode and have been verified to be working as intended on an EC2 instance running a custom build of ECS Agent.Description for the changelog
Register FIS Handlers
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.